[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip: core/rcu] rcu/nocb: Directly call __wake_nocb_gp() from bypass timer
The following commit has been merged into the core/rcu branch of tip:

Commit-ID: c7ef7500a891432a3bb2b036f535bfdf58aa3605
Author: Frederic Weisbecker <>
AuthorDate: Tue, 23 Feb 2021 01:10:05 +01:00
Committer: Paul E. McKenney <>
CommitterDate: Wed, 12 May 2021 12:10:08 -07:00

rcu/nocb: Directly call __wake_nocb_gp() from bypass timer

The bypass timer calls __call_rcu_nocb_wake() instead of directly
calling __wake_nocb_gp(). The only difference here is that
rdp->qlen_last_fqs_check gets overridden. But resetting the deferred
force quiescent state base shouldn't be relevant for that timer. In fact
the bypass queue in question can be for any rdp from the group and not
necessarily the rdp leader on which the bypass timer is attached.

This commit therefore calls __wake_nocb_gp() directly. This way we
don't even need to lock the ->nocb_lock.

Signed-off-by: Frederic Weisbecker <>
Cc: Josh Triplett <>
Cc: Lai Jiangshan <>
Cc: Joel Fernandes <>
Cc: Neeraj Upadhyay <>
Cc: Boqun Feng <>
Signed-off-by: Paul E. McKenney <>
kernel/rcu/tree_plugin.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 5a2aa9c..82e9ffb 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -2015,9 +2015,10 @@ static void do_nocb_bypass_wakeup_timer(struct timer_list *t)
struct rcu_data *rdp = from_timer(rdp, t, nocb_bypass_timer);

trace_rcu_nocb_wake(, rdp->cpu, TPS("Timer"));
- rcu_nocb_lock_irqsave(rdp, flags);
+ raw_spin_lock_irqsave(&rdp->nocb_gp_lock, flags);
smp_mb__after_spinlock(); /* Timer expire before wakeup. */
- __call_rcu_nocb_wake(rdp, true, flags);
+ __wake_nocb_gp(rdp, rdp, false, flags);

 \ /
  Last update: 2021-06-30 15:48    [W:0.028 / U:1.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site