[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V3 1/6] perf/x86/intel/uncore: Add Sapphire Rapids server support
On Tue, Jun 29, 2021 at 11:13:58AM -0700, wrote:
> From: Kan Liang <>
> Intel Sapphire Rapids supports a discovery mechanism, that allows an
> uncore driver to discover the different components ("boxes") of the
> chip.
> All the generic information of the uncore boxes should be retrieved from
> the discovery tables. This has been enabled with the commit edae1f06c2cd
> ("perf/x86/intel/uncore: Parse uncore discovery tables"). Add
> use_discovery to indicate the case. The uncore driver doesn't need to
> hard code the generic information for each uncore box.
> But we still need to enable various functionality that cannot be
> directly discovered. This is done here.
> - Add a meaningful name for each uncore block.
> - Add CHA filter support.
> - The layout of the control registers for each uncore block is a little
> bit different from the generic one. Set the platform specific format
> and ops. Expose the common ops which can be reused.
> - Add a fixed counter for IMC

Shouldn't this all be individual patches, one per new feature added?
There's a lot of stuff happening all at once here, maybe the perf
maintainers are more lax about this type of thing than other

greg k-h

 \ /
  Last update: 2021-06-30 11:40    [W:0.151 / U:3.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site