lkml.org 
[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3 v2] sh: define __BIG_ENDIAN for math-emu
    From
    Date
    On 6/28/21 12:05 AM, Randy Dunlap wrote:
    > Fix this by defining both ENDIAN macros in
    > <asm/sfp-machine.h> so that they can be utilized in
    > <math-emu/soft-fp.h> according to the latter's comment:
    > /* Allow sfp-machine to have its own byte order definitions. */
    >
    > (This is what is done in arch/nds32/include/asm/sfp-machine.h.)
    >
    > This placates these build warnings:
    >
    > In file included from ../arch/sh/math-emu/math.c:23:
    > ../include/math-emu/single.h:50:21: warning: "__BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
    > 50 | #if __BYTE_ORDER == __BIG_ENDIAN
    > In file included from ../arch/sh/math-emu/math.c:24:
    > ../include/math-emu/double.h:59:21: warning: "__BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
    > 59 | #if __BYTE_ORDER == __BIG_ENDIAN
    >
    > Fixes: 4b565680d163 ("sh: math-emu support")
    > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    > Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
    > Cc: Rich Felker <dalias@libc.org>
    > Cc: linux-sh@vger.kernel.org
    > Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
    > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    > ---
    > v2: use same preprocessor method that nds32 does;
    > add Geert's Reviewed-by;
    > renumber patches;
    > add more Cc's;
    >
    > arch/sh/include/asm/sfp-machine.h | 8 ++++++++
    > 1 file changed, 8 insertions(+)
    >
    > --- linux-next-20210625.orig/arch/sh/include/asm/sfp-machine.h
    > +++ linux-next-20210625/arch/sh/include/asm/sfp-machine.h
    > @@ -13,6 +13,14 @@
    > #ifndef _SFP_MACHINE_H
    > #define _SFP_MACHINE_H
    >
    > +#ifdef __BIG_ENDIAN__
    > +#define __BYTE_ORDER __BIG_ENDIAN
    > +#define __LITTLE_ENDIAN 0
    > +#else
    > +#define __BYTE_ORDER __LITTLE_ENDIAN
    > +#define __BIG_ENDIAN 0
    > +#endif
    > +
    > #define _FP_W_TYPE_SIZE 32
    > #define _FP_W_TYPE unsigned long
    > #define _FP_WS_TYPE signed long
    >

    Boot-tested on my SH-7785LCR without any issues.

    Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

    --
    .''`. John Paul Adrian Glaubitz
    : :' : Debian Developer - glaubitz@debian.org
    `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
    `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

    \
     
     \ /
      Last update: 2021-06-30 11:35    [W:3.358 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site