Messages in this thread | | | Subject | Re: [PATCH v5] Documentation, dt, numa: Add note to empty NUMA node | From | Gavin Shan <> | Date | Wed, 30 Jun 2021 17:26:30 +1000 |
| |
On 6/29/21 2:15 AM, Randy Dunlap wrote: > On 6/28/21 2:34 AM, Gavin Shan wrote: >> The empty memory nodes, where no memory resides in, are allowed. >> For these empty memory nodes, the 'len' of 'reg' property is zero. >> The NUMA node IDs are still valid and parsed, but memory may be >> added to them through hotplug afterwards. I finds difficulty to >> get where it's properly documented. >> >> So lets add a section for empty memory nodes in NUMA binding >> document. Also, the 'unit-address', equivalent to 'base-address' >> in the 'reg' property of these empty memory nodes is suggested to >> be the summation of highest memory address plus the NUMA node ID. >> >> Signed-off-by: Gavin Shan <gshan@redhat.com> >> --- >> v5: Separate section for empty memory node >> --- >> Documentation/devicetree/bindings/numa.txt | 61 +++++++++++++++++++++- >> 1 file changed, 60 insertions(+), 1 deletion(-) >> > > LGTM. Thanks. > > Acked-by: Randy Dunlap <rdunlap@infradead.org> >
Thanks, Randy. Rob, could you help to review? Thanks in advance.
Thanks, Gavin
| |