lkml.org 
[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ASoC: codecs: wcd938x: fix returnvar.cocci warnings
On Tue, Jun 29, 2021 at 6:59 PM kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> sound/soc/codecs/wcd938x.c:1628:5-8: Unneeded variable: "ret". Return "0" on line 1656
> sound/soc/codecs/wcd938x.c:1871:5-8: Unneeded variable: "ret". Return "0" on line 1907
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> Fixes: 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig")
> CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Acked-by: Souptick Joarder <jrdr.linux@gmail.com>

> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 73748627df83aab934c81332ca83a44ab8c7b3e3
> commit: 04544222886881cb0865040dcdf747fe7e025947 [8525/14055] ASoC: codecs: wcd938x: add audio routing and Kconfig
> :::::: branch date: 4 hours ago
> :::::: commit date: 2 weeks ago
>
> wcd938x.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/sound/soc/codecs/wcd938x.c
> +++ b/sound/soc/codecs/wcd938x.c
> @@ -1625,7 +1625,6 @@ static int wcd938x_codec_aux_dac_event(s
> {
> struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
> - int ret = 0;
>
> switch (event) {
> case SND_SOC_DAPM_PRE_PMU:
> @@ -1653,7 +1652,7 @@ static int wcd938x_codec_aux_dac_event(s
> WCD938X_ANA_RX_DIV4_CLK_EN_MASK, 0);
> break;
> }
> - return ret;
> + return 0;
>
> }
>
> @@ -1868,7 +1867,6 @@ static int wcd938x_codec_enable_aux_pa(s
> struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
> int hph_mode = wcd938x->hph_mode;
> - int ret = 0;
>
> switch (event) {
> case SND_SOC_DAPM_PRE_PMU:
> @@ -1904,7 +1902,7 @@ static int wcd938x_codec_enable_aux_pa(s
> WCD938X_EN_CUR_DET_MASK, 1);
> break;
> }
> - return ret;
> + return 0;
> }
>
> static int wcd938x_codec_enable_ear_pa(struct snd_soc_dapm_widget *w,
>

\
 
 \ /
  Last update: 2021-06-30 09:17    [W:0.043 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site