lkml.org 
[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness
From
Date
Hi Paul,
On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote:
> The MHI driver does not work on big endian architectures.  The
> controller never transitions into mission mode.  This appears to be
> due
> to the modem device expecting the various contexts and transfer rings
> to
> have fields in little endian order in memory, but the driver
> constructs
> them in native endianness.
>
> Fix MHI event, channel and command contexts and TRE handling macros
> to
> use explicit conversion to little endian.  Mark fields in relevant
> structures as little endian to document this requirement.
>
> Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
> ---
> Removed Tested-by as patch has changed somewhat from v2.
Bhaumik is going to help testing V2 on x86 platform. Change looks good
to me. Will ack it once testing is done.
> [..]
>

Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2021-07-01 03:54    [W:0.053 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site