Messages in this thread | | | Date | Thu, 3 Jun 2021 18:24:44 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v8 01/19] arm64: cpuinfo: Split AArch32 registers out into a separate struct |
| |
On Thu, Jun 03, 2021 at 01:38:52PM +0100, Mark Rutland wrote: > On Wed, Jun 02, 2021 at 05:47:01PM +0100, Will Deacon wrote: > > In preparation for late initialisation of the "sanitised" AArch32 register > > state, move the AArch32 registers out of 'struct cpuinfo' and into their > > own struct definition. > > > > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com> > > Signed-off-by: Will Deacon <will@kernel.org> > > Makes sense to me; if it's not too painful to change, I'd suggest > `aarch32` rather than `32bit` in the name, but either way: > > Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks. "32bit" is already pervasive in cpufeature.c and we're using arm64 instead of aarch64 in cpuinfo_arm64, so I'll leave this as-is and offer somebody else the refactoring opportunity ;)
Will
| |