lkml.org 
[lkml]   [2021]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: arm64: Properly restore PMU state during live-migration
Hi Jinank,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvmarm/next]
[also build test WARNING on arm/for-next soc/for-next arm64/for-next/core v5.13-rc4 next-20210603]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Jinank-Jain/KVM-arm64-Properly-restore-PMU-state-during-live-migration/20210603-190755
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/08cb3fc07cb1a68f15eb4a3e68e886c40732e699
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jinank-Jain/KVM-arm64-Properly-restore-PMU-state-during-live-migration/20210603-190755
git checkout 08cb3fc07cb1a68f15eb4a3e68e886c40732e699
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

arch/arm64/kvm/pmu.c: In function 'kvm_vcpu_pmu_restore':
>> arch/arm64/kvm/pmu.c:172:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
172 | u64 val = __vcpu_sys_reg(vcpu, PMCR_EL0);
| ^~~


vim +172 arch/arm64/kvm/pmu.c

163
164 /*
165 * Restore PMU events on first vcpu load.
166 */
167 void kvm_vcpu_pmu_restore(struct kvm_vcpu *vcpu)
168 {
169 if (kvm_arm_pmu_v3_restored(vcpu))
170 return;
171
> 172 u64 val = __vcpu_sys_reg(vcpu, PMCR_EL0);
173
174 kvm_pmu_handle_pmcr(vcpu, val);
175
176 vcpu->arch.pmu.restored = true;
177 }
178

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-06-03 17:21    [W:0.067 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site