Messages in this thread | | | Date | Thu, 03 Jun 2021 14:28:37 -0700 | From | khsieh@codeauro ... | Subject | Re: [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node |
| |
On 2021-06-03 09:53, Bjorn Andersson wrote: > On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: > >> Add DP device node on sc7180. >> >> Changes in v2: >> -- replace msm_dp with dp >> -- replace dp_opp_table with opp_table >> > > I'm sorry for those suggestions, I don't like either one of them. > > And for everything but changes to the DRM code the changelog goes below > the --- line, so it's not part of the git history. > >> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 ++++ >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 >> ++++++++++++++++++++++++++++ >> 2 files changed, 87 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> index 24d293e..40367a2 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> @@ -786,6 +786,15 @@ hp_i2c: &i2c9 { >> status = "okay"; >> }; >> >> +&dp { >> + status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&dp_hot_plug_det>; >> + data-lanes = <0 1>; > > Is it a limitation of the EC in Trogdor that you can only do 2 lanes?
yes,
> >> + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; >> + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; >> +}; >> + >> &pm6150_adc { >> charger-thermistor@4f { >> reg = <ADC5_AMUX_THM3_100K_PU>; >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index 6228ba2..05a4133 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -3032,6 +3032,13 @@ >> remote-endpoint = <&dsi0_in>; >> }; >> }; >> + >> + port@2 { >> + reg = <2>; >> + dpu_intf0_out: endpoint { >> + remote-endpoint = <&dp_in>; >> + }; >> + }; >> }; >> >> mdp_opp_table: mdp-opp-table { >> @@ -3148,6 +3155,77 @@ >> >> status = "disabled"; >> }; >> + >> + dp: displayport-controller@ae90000 { > > If you label this "mdss_dp", then it will naturally group with other > mdss properties in trogdor.dtsi (which should be sorted > alphabetically). > >> + compatible = "qcom,sc7180-dp"; >> + status = "disabled"; >> + >> + reg = <0 0x0ae90000 0 0x1400>; >> + >> + interrupt-parent = <&mdss>; >> + interrupts = <12>; >> + >> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_AUX_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_LINK_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>; >> + clock-names = "core_iface", "core_aux", "ctrl_link", >> + "ctrl_link_iface", "stream_pixel"; >> + #clock-cells = <1>; >> + assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>, >> + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>; >> + assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>; >> + phys = <&dp_phy>; >> + phy-names = "dp"; >> + >> + operating-points-v2 = <&opp_table>; >> + power-domains = <&rpmhpd SC7180_CX>; > > Just curious, but isn't the DP block in the MDSS_GDCS? Or do we need to > mention CX here in order for the opp framework to apply required-opps > of CX? > >> + >> + #sound-dai-cells = <0>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + port@0 { >> + reg = <0>; >> + dp_in: endpoint { >> + remote-endpoint = <&dpu_intf0_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + dp_out: endpoint { }; >> + }; >> + }; >> + >> + opp_table: dp-opp-table { > > The one and only "opp_table" of the sc7180 :) > Maybe name it dp_opp_table instead? > > Regards, > Bjorn > >> + compatible = "operating-points-v2"; >> + >> + opp-160000000 { >> + opp-hz = /bits/ 64 <160000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-270000000 { >> + opp-hz = /bits/ 64 <270000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-540000000 { >> + opp-hz = /bits/ 64 <540000000>; >> + required-opps = <&rpmhpd_opp_svs_l1>; >> + }; >> + >> + opp-810000000 { >> + opp-hz = /bits/ 64 <810000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + }; >> + }; >> + }; >> + >> + >> }; >> >> dispcc: clock-controller@af00000 { >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >>
| |