lkml.org 
[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] printk/console: Check consistent sequence number when handling race in console_unlock()
Date
On 2021-06-30, kernel test robot <lkp@intel.com> wrote:
>>> kernel/printk/printk.c:2548:6: warning: variable 'next_seq' set but not used [-Wunused-but-set-variable]

I suppose the correct fix for this warning would be to change the NOP
macros. Currently they are:

#define prb_read_valid(rb, seq, r) false
#define prb_first_valid_seq(rb) 0

They should probably be something like (untested):

#define prb_read_valid(rb, seq, r) \
({ \
(void)(rb); \
(void)(seq); \
(void)(r); \
false; \
})

#define prb_first_valid_seq(rb) \
({ \
(void)(rb); \
0; \
})

John Ogness

\
 
 \ /
  Last update: 2021-06-29 22:55    [W:0.059 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site