Messages in this thread | | | Subject | Re: [PATCH 1/3] checkpatch: skip spacing tests on linker scripts | From | Joe Perches <> | Date | Tue, 29 Jun 2021 13:01:05 -0700 |
| |
On Tue, 2021-06-29 at 13:50 -0600, jim.cromie@gmail.com wrote: > this does 3 different things > > - non-capturing matches - these add no functionality,
true, it's nominally a bit faster through.
> - moves the skip-remaining-tests check after SPDX > that feels like a legal Q: should it be on all files ? > moving it does seem proper though.
to me too.
> - adds the skip linker-script > since i went ahead and added it 3 times to see errs/warns > I didnt consider your precise placement, > how does it do with 18/8 errs/warnings on ref-test ?
$ ./scripts/checkpatch.pl -f include/asm-generic/vmlinux.lds.h --strict --terse include/asm-generic/vmlinux.lds.h:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 include/asm-generic/vmlinux.lds.h:43: WARNING: please, no space before tabs include/asm-generic/vmlinux.lds.h:101: CHECK: line length of 106 exceeds 100 columns include/asm-generic/vmlinux.lds.h:390: WARNING: please, no space before tabs include/asm-generic/vmlinux.lds.h:546: ERROR: code indent should use tabs where possible total: 1 errors, 3 warnings, 1 checks, 1184 lines checked
| |