lkml.org 
[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv1] arm64: amlogic: Fix the pwm regulator supply property in node
Hi Anand,

thanks for investigating this and for sending a fix!

On Tue, Jun 29, 2021 at 2:19 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> On enable CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
see my comment on the previous patch

> Changes help link VDDCPU_A and VDDCPU_B pwm regulator to 12V regulator
> supply instead of dummy regulator.
>
> [ 4.147196] VDDCPU_A: will resolve supply early: pwm
> [ 4.147216] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply from device tree
> [ 4.147227] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply property in node /regulator-vddcpu-a failed
> [ 4.147258] VDDCPU_A: supplied by regulator-dummy
> [ 4.147288] regulator-dummy: could not add device link regulator.12: -ENOENT
> [ 4.147353] VDDCPU_A: 721 <--> 1022 mV at 871 mV, enabled
> [ 4.152014] VDDCPU_B: will resolve supply early: pwm
> [ 4.152035] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply from device tree
> [ 4.152047] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply property in node /regulator-vddcpu-b failed
> [ 4.152079] VDDCPU_B: supplied by regulator-dummy
> [ 4.152108] regulator-dummy: could not add device link regulator.13: -ENOENT
>
> Fixes: d14734a04a8a ("arm64: dts: meson-g12b-odroid-n2: enable DVFS")
I suggest changing the subject to include "dts", for example:
arm64: dts: amlogic: ...
(note: lower-case arm64 is correct here - even though it's different
from the 32-bit ARM prefix)

$ grep -lR pwm-regulator arch/arm64/boot/dts/amlogic/
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
Are you planning to also send patches for the other board .dts as well?


Best regards,
Martin

\
 
 \ /
  Last update: 2021-06-29 18:09    [W:0.196 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site