lkml.org 
[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] phy: mscc: Add support for VSC8531_02 with RGMII tuning
Hi Heiner,

On Tue, Jun 29, 2021 at 4:11 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 29.06.2021 11:40, Harini Katakam wrote:
> > Add support for VSC8531_02 (Rev 2) device.
> > Add support for optional RGMII RX and TX delay tuning via devicetree.
> > The hierarchy is:
> > - Retain the defaul 0.2ns delay when RGMII tuning is not set.
> > - Retain the default 2ns delay when RGMII tuning is set and DT delay
> > property is NOT specified.
> > - Use the DT delay value when RGMII tuning is set and a DT delay
> > property is specified.
> >
> > Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > ---
> > drivers/net/phy/mscc/mscc.h | 3 +++
> > drivers/net/phy/mscc/mscc_main.c | 41 ++++++++++++++++++++++++++++++--
> > 2 files changed, 42 insertions(+), 2 deletions(-)
> >
<snip>
> {
> > .phy_id = PHY_ID_VSC8540,
> > .name = "Microsemi FE VSC8540 SyncE",
> > @@ -2668,6 +2704,7 @@ static struct mdio_device_id __maybe_unused vsc85xx_tbl[] = {
> > { PHY_ID_VSC8514, 0xfffffff0, },
> > { PHY_ID_VSC8530, 0xfffffff0, },
> > { PHY_ID_VSC8531, 0xfffffff0, },
> > + { PHY_ID_VSC8531_02, 0xfffffff0, },
>
> Effectively this is the same as the line before. Maybe it would make sense
> to change this table in a follow-up patch to just one entry covering all
> PHY ID's with the vendor part being Microsemi, e.g. using macro
> PHY_ID_MATCH_VENDOR().

Thanks for the review. Let me check and test - I have a couple of these parts.
Will try to include the patch in this series.

Regards,
Harini

\
 
 \ /
  Last update: 2021-06-29 16:20    [W:0.058 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site