lkml.org 
[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 09/13] irqchip/gic: Rely on MSI default .irq_eoi()
    Date
    Previously, only platform-MSI irqchips would get a default .irq_eoi().
    GIC-based platform-MSI irqchip's rely on this default callback, while
    PCI-MSI ones are initialized explicitly.

    As all MSI domains now get a default .irq_eoi(), drop the explicit
    .irq_eoi() initialization for PCI-MSI chips.

    Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
    ---
    drivers/irqchip/irq-gic-v2m.c | 1 -
    drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 1 -
    drivers/irqchip/irq-gic-v3-its-pci-msi.c | 1 -
    drivers/irqchip/irq-gic-v3-mbi.c | 1 -
    4 files changed, 4 deletions(-)

    diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
    index be9ea6fd6f8b..27a97c76ba0d 100644
    --- a/drivers/irqchip/irq-gic-v2m.c
    +++ b/drivers/irqchip/irq-gic-v2m.c
    @@ -87,7 +87,6 @@ static struct irq_chip gicv2m_msi_irq_chip = {
    .name = "MSI",
    .irq_mask = gicv2m_mask_msi_irq,
    .irq_unmask = gicv2m_unmask_msi_irq,
    - .irq_eoi = irq_chip_eoi_parent,
    .irq_write_msi_msg = pci_msi_domain_write_msg,
    };

    diff --git a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c
    index 634263dfd7b5..105ee646cd12 100644
    --- a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c
    +++ b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c
    @@ -21,7 +21,6 @@ static struct irq_chip its_msi_irq_chip = {
    .name = "ITS-fMSI",
    .irq_mask = irq_chip_mask_parent,
    .irq_unmask = irq_chip_unmask_parent,
    - .irq_eoi = irq_chip_eoi_parent,
    .irq_set_affinity = msi_domain_set_affinity
    };

    diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
    index ad2810c017ed..14f6e63c630c 100644
    --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
    +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
    @@ -27,7 +27,6 @@ static struct irq_chip its_msi_irq_chip = {
    .name = "ITS-MSI",
    .irq_unmask = its_unmask_msi_irq,
    .irq_mask = its_mask_msi_irq,
    - .irq_eoi = irq_chip_eoi_parent,
    .irq_write_msi_msg = pci_msi_domain_write_msg,
    };

    diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c
    index e81e89a81cb5..a69ac299a533 100644
    --- a/drivers/irqchip/irq-gic-v3-mbi.c
    +++ b/drivers/irqchip/irq-gic-v3-mbi.c
    @@ -169,7 +169,6 @@ static struct irq_chip mbi_msi_irq_chip = {
    .name = "MSI",
    .irq_mask = mbi_mask_msi_irq,
    .irq_unmask = mbi_unmask_msi_irq,
    - .irq_eoi = irq_chip_eoi_parent,
    .irq_compose_msi_msg = mbi_compose_msi_msg,
    .irq_write_msi_msg = pci_msi_domain_write_msg,
    };
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-06-29 15:10    [W:4.837 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site