[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform drvdata
    Em Tue, 29 Jun 2021 18:48:31 +0800
    Axel Lin <> escreveu:

    > Mauro Carvalho Chehab <> 於 2021年6月29日 週二 下午6:31寫道:
    > > platform drvdata can't be used inside the regulator driver,
    > > as this is already used by the MFD and SPMI drivers.
    > >
    > Could you point out which part of the code set the platform drvdata?
    > My understanding is the mfd only set dev->platform_data rather than
    > dev->driver_data.
    > If you mean the dev_set_drvdata() call in hi6421_spmi_pmic_probe, it's the
    > parent device of the regulator pdev.

    It needs to be double-checked, but I guess the SPMI or the SPMI controller
    driver already uses it.

    See, there are 5 drivers involved, all of them using private data
    and passing data to child drivers, called on the order below:

    mfd drivers:

    If you're in doubt, try to apply this series, and then change the
    driver again to use platform data. You'll see that it will stop
    booting after initializing the first regulator.


     \ /
      Last update: 2021-06-29 13:10    [W:27.023 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site