lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/tools/relocs: Mark die() with the printf function attr format
On Mon, Jun 28, 2021 at 04:25:45PM +0200, Borislav Petkov wrote:
> On Sun, Jun 27, 2021 at 05:01:28PM +0200, Greg Kroah-Hartman wrote:
> > This works for me! It should fix the static checking tool that keeps
> > tripping over this pointless warning :)
> >
> > Want to turn it into a real patch?
>
> How's that?
>
> ---
> From: Borislav Petkov <bp@suse.de>
>
> Mark die() as a function which accepts printf-style arguments so that
> the compiler can typecheck them against the supplied format string.
>
> Use the C99 inttypes.h format specifiers as relocs.c gets built for both
> 32- and 64-bit.
>
> Original version of the patch by Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> arch/x86/tools/relocs.c | 37 ++++++++++++++++++++-----------------
> arch/x86/tools/relocs.h | 1 +
> 2 files changed, 21 insertions(+), 17 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

\
 
 \ /
  Last update: 2021-06-28 17:10    [W:6.305 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site