lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 007/109] gfs2: Prevent direct-I/O write fallback errors from getting lost
    Date
    From: Andreas Gruenbacher <agruenba@redhat.com>

    [ Upstream commit 43a511c44e58e357a687d61a20cf5ef1dc9e5a7c ]

    When a direct I/O write falls entirely and falls back to buffered I/O and the
    buffered I/O fails, the write failed with return value 0 instead of the error
    number reported by the buffered I/O. Fix that.

    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/gfs2/file.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
    index 143e7d518c5d..7c69486d556f 100644
    --- a/fs/gfs2/file.c
    +++ b/fs/gfs2/file.c
    @@ -822,8 +822,11 @@ static ssize_t gfs2_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
    current->backing_dev_info = inode_to_bdi(inode);
    buffered = iomap_file_buffered_write(iocb, from, &gfs2_iomap_ops);
    current->backing_dev_info = NULL;
    - if (unlikely(buffered <= 0))
    + if (unlikely(buffered <= 0)) {
    + if (!ret)
    + ret = buffered;
    goto out_unlock;
    + }

    /*
    * We need to ensure that the page cache pages are written to
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 16:51    [W:4.877 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site