lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 022/101] dmaengine: zynqmp_dma: Fix PM reference leak in zynqmp_dma_alloc_chan_resourc()
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    [ Upstream commit 8982d48af36d2562c0f904736b0fc80efc9f2532 ]

    pm_runtime_get_sync will increment pm usage counter even it failed.
    Forgetting to putting operation will result in reference leak here.
    Fix it by replacing it with pm_runtime_resume_and_get to keep usage
    counter balanced.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    Link: https://lore.kernel.org/r/20210517081826.1564698-4-yukuai3@huawei.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/xilinx/zynqmp_dma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
    index d8419565b92c..5fecf5aa6e85 100644
    --- a/drivers/dma/xilinx/zynqmp_dma.c
    +++ b/drivers/dma/xilinx/zynqmp_dma.c
    @@ -468,7 +468,7 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_chan *dchan)
    struct zynqmp_dma_desc_sw *desc;
    int i, ret;

    - ret = pm_runtime_get_sync(chan->dev);
    + ret = pm_runtime_resume_and_get(chan->dev);
    if (ret < 0)
    return ret;

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 16:35    [W:2.734 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site