lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v9 3/5] mfd: hi6421-spmi-pmic: move driver from staging
    On Fri, Jun 25, 2021 at 07:06:12PM +0200, Mauro Carvalho Chehab wrote:
    > +static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
    > +{
    > + struct device *dev = &pdev->dev;
    > + int ret;
    > + struct hi6421_spmi_pmic *ddata;
    > + ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL);

    No blank line. Checkpatch.

    > + if (!ddata)
    > + return -ENOMEM;
    > +
    > + ddata->regmap = devm_regmap_init_spmi_ext(pdev, &regmap_config);
    > + if (IS_ERR(ddata->regmap))
    > + return PTR_ERR(ddata->regmap);
    > +
    > + mutex_init(&ddata->enable_mutex);
    > +
    > + dev_set_drvdata(&pdev->dev, ddata);
    > +
    > + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
    > + hi6421v600_devs, ARRAY_SIZE(hi6421v600_devs),
    > + NULL, 0, NULL);
    > + if (ret < 0)
    > + dev_err(dev, "Failed to add child devices: %d\n", ret);
    > +
    > + return ret;
    > +}

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2021-06-28 10:14    [W:5.665 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site