[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2] kunit: tool: remove unnecessary "annotations" import
The import was working around the fact "tuple[T]" was used instead of

Convert it to use typing.Tuple to be consistent with how the rest of the
code is annotated.

Signed-off-by: Daniel Latypov <>
Reviewed-by: David Gow <>
Reviewed-by: Brendan Higgins <>
Tested-by: Brendan Higgins <>
v1 -> v2: fix typos in commit message.
tools/testing/kunit/ | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/testing/kunit/ b/tools/testing/kunit/
index 90bc007f1f93..2c6f916ccbaf 100644
--- a/tools/testing/kunit/
+++ b/tools/testing/kunit/
@@ -6,15 +6,13 @@
# Author: Felix Guo <>
# Author: Brendan Higgins <>

-from __future__ import annotations
import importlib.util
import logging
import subprocess
import os
import shutil
import signal
-from typing import Iterator
-from typing import Optional
+from typing import Iterator, Optional, Tuple

from contextlib import ExitStack

@@ -208,7 +206,7 @@ def get_source_tree_ops(arch: str, cross_compile: Optional[str]) -> LinuxSourceT
raise ConfigError(arch + ' is not a valid arch')

def get_source_tree_ops_from_qemu_config(config_path: str,
- cross_compile: Optional[str]) -> tuple[
+ cross_compile: Optional[str]) -> Tuple[
str, LinuxSourceTreeOperations]:
# The module name/path has very little to do with where the actual file
# exists (I learned this through experimentation and could not find it
base-commit: 1d71307a6f94df3750f8f884545a769e227172fe

 \ /
  Last update: 2021-06-29 02:39    [W:0.038 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site