Messages in this thread | | | From | Nicolas Boichat <> | Date | Tue, 29 Jun 2021 07:44:44 +0800 | Subject | Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features |
| |
On Mon, Jun 28, 2021 at 7:10 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat <drinkcat@chromium.org> wrote: > > On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > > dsi->mode_flags = > > > > MIPI_DSI_CLOCK_NON_CONTINUOUS | > > > > - MIPI_DSI_MODE_EOT_PACKET; > > > > + MIPI_DSI_MODE_NO_EOT_PACKET; > > > > > > Same, just delete the flag. > > > > > > These are all just semantic bugs due to the ambiguity of the flags, it is > > > possible to provide a Fixes: flag for each file using this flag the wrong way > > > but I dunno if it's worth it. > > > > Wow nice catch. > > > > I think we should fix all of those _before_ my patch is applied, with > > proper Fixes tags so that this can be backported to stable branches, > > even if it's a no-op. I can look into it but that may take a bit of > > time. > > This is fixed now, please will you proceed with this patch, because I > really like it!
Thanks for the ping, that fell off my radar, v2 on its way ,-)
> Yours, > Linus Walleij
| |