lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] spi: <linux/spi/spi.h>: add missing struct kernel-doc entry
From
Date
On 6/28/21 12:05 AM, Lukas Wunner wrote:
> On Sun, Jun 27, 2021 at 05:40:23PM -0700, Randy Dunlap wrote:
>> --- linux-next-20210625.orig/include/linux/spi/spi.h
>> +++ linux-next-20210625/include/linux/spi/spi.h
>> @@ -339,6 +339,7 @@ extern struct spi_device *spi_new_ancill
>> * @max_speed_hz: Highest supported transfer speed
>> * @flags: other constraints relevant to this driver
>> * @slave: indicates that this is an SPI slave controller
>> + * @devm_allocated: flag indicating this is a non-devres managed controller
>
> Actually the flag indicates that the *allocation* of the controller *is*
> devres-managed, so instead of the above I'd suggest something along the
> lines of:
>
> * @devm_allocated: whether allocation of this struct is devres-managed
>
> Thanks,

Hi Lukas,

OK, I'll change it like that.
I had just copied a comment from below in that same file.
I think that I should fix that comment as well.

Thanks.

\
 
 \ /
  Last update: 2021-06-28 18:57    [W:0.068 / U:2.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site