Messages in this thread | | | Date | Mon, 28 Jun 2021 15:53:07 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH] regulator: devres: disable regulator on release if refcount is 1 |
| |
On Fri, Jun 25, 2021 at 03:53:07PM +0300, Alexandru Ardelean wrote:
> This means that the last 'regulator_disable()' (on driver remove) becomes > optional. > If there are any unbalanced regulator_enable()/regulator_disable() calls, > the 'enable_count' won't be touched and 'regulator_put()' will print a > warning.
This doesn't seem like it's going to make reviewing and debugging reference counting issues any easier, it seems even more of a concern than a devm version TBH. It's also not clear why if we were doing this we'd restrict it to a single reference. [unhandled content-type:application/pgp-signature] | |