[lkml]   [2021]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] gpio: mt7621: support gpio-line-names property
On Sat, Jun 26, 2021 at 7:18 PM Sergio Paracuellos
<> wrote:
> The default handling of the gpio-line-names property by the
> gpiolib-of implementation does not work with the multiple
> gpiochip banks per device structure used by the gpio-mt7621
> driver.
> This commit adds driver level support for the device tree
> property so that GPIO lines can be assigned friendly names.

> Signed-off-by: Sergio Paracuellos <>
> ---
> Hi,
> This driver has three gpiochips with 32 gpios each. Core implementation


> got gpio's repeated along each gpio chip if chip.names is not assigned.
> To avoid this behaviour driver will set this names as empty or

the driver
these names

> with desired friendly line names. Consider the following sample with
> minimal entries for the first chip with this patch changes applied:

The same comment as per v1:

Any idea why it's not a duplicate of,
and why the latter is not called in your case?

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2021-06-27 11:35    [W:0.050 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site