lkml.org 
[lkml]   [2021]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 6/9] xfs: Implement ->corrupted_range() for XFS
Hi Shiyang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.13]
[cannot apply to hnaz-linux-mm/master xfs-linux/for-next dm/for-next next-20210625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20210628-080346
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 62fb9874f5da54fdb243003b386128037319b219
config: x86_64-randconfig-a002-20210628 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4c92e31dd0f1bd152eda883af20ff7fbcaa14945)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/6833b9441ae13413e20968838cd8de34b8c69ed4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20210628-080346
git checkout 6833b9441ae13413e20968838cd8de34b8c69ed4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

fs/xfs/xfs_super.c:1103:10: warning: unused variable 'flags' [-Wunused-variable]
int *flags = data;
^
>> fs/xfs/xfs_super.c:1101:25: warning: variable 'mapping' set but not used [-Wunused-but-set-variable]
struct address_space *mapping;
^
2 warnings generated.


vim +/mapping +1101 fs/xfs/xfs_super.c

1093
1094 static int
1095 xfs_corrupt_helper(
1096 struct xfs_btree_cur *cur,
1097 struct xfs_rmap_irec *rec,
1098 void *data)
1099 {
1100 struct xfs_inode *ip;
> 1101 struct address_space *mapping;
1102 int error = 0;
1103 int *flags = data;
1104
1105 if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) ||
1106 (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) {
1107 // TODO check and try to fix metadata
1108 xfs_force_shutdown(cur->bc_mp, SHUTDOWN_CORRUPT_META);
1109 return -EFSCORRUPTED;
1110 }
1111
1112 /*
1113 * Get files that incore, filter out others that are not in use.
1114 */
1115 error = xfs_iget(cur->bc_mp, cur->bc_tp, rec->rm_owner, XFS_IGET_INCORE,
1116 0, &ip);
1117 if (error)
1118 return error;
1119
1120 mapping = VFS_I(ip)->i_mapping;
1121

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-06-28 04:03    [W:0.122 / U:1.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site