lkml.org 
[lkml]   [2021]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] libnvdimm, badrange: replace div_u64_rem with DIV_ROUND_UP
Date
__add_badblock_range use div_u64_rem to round up end_sector and it will
introduces unnecessary rem define and costly '%' operation. So clean it
with DIV_ROUND_UP.

Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
---
drivers/nvdimm/badrange.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/nvdimm/badrange.c b/drivers/nvdimm/badrange.c
index aaf6e215a8c6..28e73506d85e 100644
--- a/drivers/nvdimm/badrange.c
+++ b/drivers/nvdimm/badrange.c
@@ -187,12 +187,9 @@ static void __add_badblock_range(struct badblocks *bb, u64 ns_offset, u64 len)
const unsigned int sector_size = 512;
sector_t start_sector, end_sector;
u64 num_sectors;
- u32 rem;

start_sector = div_u64(ns_offset, sector_size);
- end_sector = div_u64_rem(ns_offset + len, sector_size, &rem);
- if (rem)
- end_sector++;
+ end_sector = end_sector = DIV_ROUND_UP(ns_offset + len, sector_size);
num_sectors = end_sector - start_sector;

if (unlikely(num_sectors > (u64)INT_MAX)) {
--
2.23.0
--
Best wishes
Kemeng Shi

\
 
 \ /
  Last update: 2021-06-26 05:31    [W:0.155 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site