lkml.org 
[lkml]   [2021]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/23] staging: rtl8188eu: remove include/rtw_debug.h
On Fri, Jun 25, 2021 at 03:43:56PM +0300, Dan Carpenter wrote:
> Looks good.
>
> I feel like the kbuild warnings could be addressed in later patches.
>
> It seems as if some of the error handling in this driver is "pretend to
> print an error message (but it's actually dead code)". Which is
> probably not the correct way to handle errors... :/ But that's not
> something introduced by this patch.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>

Dear Dan,

Thank you for your feedback, and have a great weekend.

Regards,
Phil

\
 
 \ /
  Last update: 2021-06-25 19:43    [W:0.122 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site