Messages in this thread | | | Date | Fri, 25 Jun 2021 18:42:52 +0100 | From | Phillip Potter <> | Subject | Re: [PATCH 00/23] staging: rtl8188eu: remove include/rtw_debug.h |
| |
On Fri, Jun 25, 2021 at 03:43:56PM +0300, Dan Carpenter wrote: > Looks good. > > I feel like the kbuild warnings could be addressed in later patches. > > It seems as if some of the error handling in this driver is "pretend to > print an error message (but it's actually dead code)". Which is > probably not the correct way to handle errors... :/ But that's not > something introduced by this patch. > > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> > > regards, > dan carpenter >
Dear Dan,
Thank you for your feedback, and have a great weekend.
Regards, Phil
| |