lkml.org 
[lkml]   [2021]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch V3 37/66] x86/fpu: Rename "dynamic" XSTATEs to "independent"
    On Fri, Jun 18, 2021 at 04:19:00PM +0200, Thomas Gleixner wrote:
    > --- a/arch/x86/include/asm/fpu/xstate.h
    > +++ b/arch/x86/include/asm/fpu/xstate.h
    > @@ -56,7 +56,7 @@
    > * - Don't set the bit corresponding to the dynamic supervisor feature in
    > * IA32_XSS at run time, since it has been set at boot time.
    > */
    > -#define XFEATURE_MASK_DYNAMIC (XFEATURE_MASK_LBR)
    > +#define XFEATURE_MASK_INDEPENDENT (XFEATURE_MASK_LBR)

    Yah, you kinda missed all those "dynamic" in the comment here explaining
    what this mask means.

    Do a

    $ git grep dynamic arch/x86/

    after renaming to make sure you've caught them all.

    > @@ -1199,34 +1199,34 @@ void copy_dynamic_supervisor_to_kernel(s
    > }
    >
    > /**
    > - * copy_kernel_to_dynamic_supervisor() - Restore dynamic supervisor states from
    > - * an xsave area
    > + * copy_kernel_to_independent_supervisor() - Restore independent supervisor states from
    > + * an xsave area
    > * @xstate: A pointer to an xsave area
    > - * @mask: Represent the dynamic supervisor features restored from the xsave area
    > + * @mask: Represent the independent supervisor features restored from the xsave area
    > *
    > - * Only the dynamic supervisor states sets in the mask are restored from the
    > - * xsave area (See the comment in XFEATURE_MASK_DYNAMIC for the details of
    > - * dynamic supervisor feature). Besides the dynamic supervisor states, the
    > + * Only the independent supervisor states sets in the mask are restored from the
    > + * xsave area (See the comment in XFEATURE_MASK_INDEPENDENT for the details of
    > + * independent supervisor feature). Besides the independent supervisor states, the
    > * legacy region and XSAVE header are also restored from the xsave area. The
    > * supervisor features in the XFEATURE_MASK_SUPERVISOR_SUPPORTED and
    > * XFEATURE_MASK_SUPERVISOR_UNSUPPORTED are not restored.
    > *
    > * The xsave area must be 64-bytes aligned.
    > */
    > -void copy_kernel_to_dynamic_supervisor(struct xregs_state *xstate, u64 mask)
    > +void copy_kernel_to_independent_supervisor(struct xregs_state *xstate, u64 mask)

    Well, can't say I'm crazy about the naming which is a mouthful and
    reminds me of an "independent supervisor", i.e., like some United
    Nations thing.

    --
    Regards/Gruss,
    Boris.

    SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

    \
     
     \ /
      Last update: 2021-06-22 13:06    [W:2.964 / U:0.840 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site