Messages in this thread | | | Subject | Re: [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO | From | Peter Oberparleiter <> | Date | Tue, 22 Jun 2021 11:35:37 +0200 |
| |
On 22.06.2021 01:18, Nick Desaulniers wrote: > We don't want compiler instrumentation to touch noinstr functions, which > are annotated with the no_profile_instrument_function function > attribute. Add a Kconfig test for this and make PGO and GCOV depend on > it. > > If an architecture is using noinstr, it should denote that via this > Kconfig value. That makes Kconfigs that depend on noinstr able to > express dependencies in an architecturally agnostic way. > > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com> > Link: https://lore.kernel.org/lkml/YMTn9yjuemKFLbws@hirez.programming.kicks-ass.net/ > Link: https://lore.kernel.org/lkml/YMcssV%2Fn5IBGv4f0@hirez.programming.kicks-ass.net/ > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Looks good to me - thanks for resolving this problem!
Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Regards, Peter
-- Peter Oberparleiter Linux on Z Development - IBM Germany
| |