Messages in this thread | | | Subject | Re: [PATCH v2] io_uring: reduce latency by reissueing the operation | From | Pavel Begunkov <> | Date | Sun, 20 Jun 2021 21:08:41 +0100 |
| |
On 6/20/21 9:01 PM, Randy Dunlap wrote: > On 6/20/21 12:28 PM, Olivier Langlois wrote: >> On Sun, 2021-06-20 at 12:07 -0700, Randy Dunlap wrote: >>> On 6/20/21 12:05 PM, Olivier Langlois wrote: >>>> - return false; >>>> + return ret?IO_ARM_POLL_READY:IO_ARM_POLL_ERR; >>> >>> Hi, >>> Please make that return expression more readable. >>> >>> >> How exactly? >> >> by adding spaces? >> Changing the define names?? > > Adding spaces would be sufficient IMO (like Pavel suggested also).
Agree. That should be in the code style somewhere
-- Pavel Begunkov
| |