Messages in this thread | | | Subject | Re: [PATCH] sched/fair: Fix util_est UTIL_AVG_UNCHANGED handling | From | Dietmar Eggemann <> | Date | Wed, 2 Jun 2021 16:58:39 +0200 |
| |
On 28/05/2021 08:25, Xuewen Yan wrote: > On Fri, May 28, 2021 at 6:38 AM Dietmar Eggemann > <dietmar.eggemann@arm.com> wrote: >> >> On 27/05/2021 07:41, Xuewen Yan wrote: >>> Hi >>> >>> On Wed, May 26, 2021 at 10:59 PM Dietmar Eggemann >>> <dietmar.eggemann@arm.com> wrote: >>>> >>>> On 19/05/2021 18:06, Vincent Donnefort wrote: >>>>> On Fri, May 14, 2021 at 12:37:48PM +0200, Dietmar Eggemann wrote:
[...]
>>> IMHO, Maybe it would be better to put it in the util_est structure >>> just like UTIL_EST_WEIGHT_SHIFT? >> >> Yeah, can do. >> >> I just realized that 'kernel/sched/pelt.h' does not include >> <linux/sched.h> directly (or indirectly via "sched.h". But I can easily >> move cfs_se_util_change() (which uses UTIL_AVG_UNCHANGED) from pelt.h to >> pelt.c, its only consumer anyway. > > Since there are so many questions, why not add ( #include "pelt.h" ) > directly into (kernel/sched/debug.c)? > > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index 9c882f20803e..dde91171d4ae 100644 > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -7,6 +7,7 @@ > * Copyright(C) 2007, Red Hat, Inc., Ingo Molnar > */ > #include "sched.h" > +#include "pelt.h"
Didn't want to expose PELT internals unnecessarily.
And ... turns out that the include dependency `"sched.h" before "pelt.h"` exists for much more things than just UTIL_AVG_UNCHANGED. So I think I don't have to care about the issue in this case.
I sent out a v2 addressing your comment.
| |