lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: greybus: fixed the coding style, labels should not be indented.
On Wed, Jun 02, 2021 at 07:57:35PM +0530, Manikishan Ghantasala wrote:
> Sending this mail again as I missed to reply to all.
> Hi Alex,
>
> I agree those are called bit-field member names rather than labels.
> But the reason I mentioned is because the ./scripts/checkpatch.pl
> gave out a warning saying "labels should not be indented".

checkpatch is a perl script that does it's best, but does not always get
it right. In this case, it is incorrect, the existing code is just
fine.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-06-02 16:38    [W:0.132 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site