lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 2/2] gpio: dwapb: Switch to use fwnode_irq_get()
On Tue, Jun 1, 2021 at 6:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> We have open coded variant of fwnode_irq_get() in dwapb_get_irq().
> Replace it with a simple call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-dwapb.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 939701c1465e..7d61f5821e32 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -528,17 +528,13 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> static void dwapb_get_irq(struct device *dev, struct fwnode_handle *fwnode,
> struct dwapb_port_property *pp)
> {
> - struct device_node *np = NULL;
> - int irq = -ENXIO, j;
> -
> - if (fwnode_property_read_bool(fwnode, "interrupt-controller"))
> - np = to_of_node(fwnode);
> + int irq, j;
>
> for (j = 0; j < pp->ngpio; j++) {
> - if (np)
> - irq = of_irq_get(np, j);
> - else if (has_acpi_companion(dev))
> + if (has_acpi_companion(dev))
> irq = platform_get_irq_optional(to_platform_device(dev), j);
> + else
> + irq = fwnode_irq_get(fwnode, j);
> if (irq > 0)
> pp->irq[j] = irq;
> }
> --
> 2.30.2
>

Applied, thanks!

Bart

\
 
 \ /
  Last update: 2021-06-02 15:37    [W:0.104 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site