lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] regulator: core: always use enable_delay when enabling regulators
On Thu, 20 May 2021 at 14:58, Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, May 20, 2021 at 01:12:24AM +0300, Dmitry Baryshkov wrote:
> > Some regulators (e.g. fixed) do not have .enable callback per se, but
> > use supply regulator and enable_delay. Do not return early from
> > _regulator_do_enable in such cases, so that enable_delay is properly
> > handled.
>
> This doesn't seem like the right fix - if we didn't actually do anything
> then we don't need to add a delay. We should only be doing this if some
> parent regulator changed state.

I have implemented this, but then it becomes too fragile. If the
parent gets enabled for whatever reason just few us ago, the whole
delay would be skipped.

--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2021-06-02 15:16    [W:0.113 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site