lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 04/21] ide: ide-io: Fix a few kernel-doc misdemeanours
Date
Fixes the following W=1 kernel build warning(s):

drivers/ide/ide-io.c:268: warning: expecting prototype for execute_drive_command(). Prototype was for execute_drive_cmd() instead
drivers/ide/ide-io.c:320: warning: Function parameter or member 'drive' not described in 'start_request'
drivers/ide/ide-io.c:320: warning: Function parameter or member 'rq' not described in 'start_request'
drivers/ide/ide-io.c:618: warning: Function parameter or member 't' not described in 'ide_timer_expiry'
drivers/ide/ide-io.c:618: warning: Excess function parameter 'data' description in 'ide_timer_expiry'
drivers/ide/ide-io.c:775: warning: Excess function parameter 'regs' description in 'ide_intr'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ide/ide-io.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 4867b67b60d69..bd3e78985bcc7 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -252,7 +252,7 @@ void ide_init_sg_cmd(struct ide_cmd *cmd, unsigned int nr_bytes)
EXPORT_SYMBOL_GPL(ide_init_sg_cmd);

/**
- * execute_drive_command - issue special drive command
+ * execute_drive_cmd - issue special drive command
* @drive: the drive to issue the command on
* @rq: the request structure holding the command
*
@@ -309,6 +309,8 @@ static ide_startstop_t ide_special_rq(ide_drive_t *drive, struct request *rq)

/**
* start_request - start of I/O and command issuing for IDE
+ * @drive: the drive to issue the command on
+ * @rq: the request structure holding the command
*
* start_request() initiates handling of a new I/O request. It
* accepts commands and I/O (read/write) requests.
@@ -602,7 +604,7 @@ static int drive_is_ready(ide_drive_t *drive)

/**
* ide_timer_expiry - handle lack of an IDE interrupt
- * @data: timer callback magic (hwif)
+ * @t: timer callback magic (hwif)
*
* An IDE command has timed out before the expected drive return
* occurred. At this point we attempt to clean up the current
@@ -748,9 +750,7 @@ static void unexpected_intr(int irq, ide_hwif_t *hwif)

/**
* ide_intr - default IDE interrupt handler
- * @irq: interrupt number
* @dev_id: hwif
- * @regs: unused weirdness from the kernel irq layer
*
* This is the default IRQ handler for the IDE layer. You should
* not need to override it. If you do be aware it is subtle in
--
2.31.1
\
 
 \ /
  Last update: 2021-06-02 12:18    [W:0.144 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site