lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/4] scsi: ufs: Use UPIU query trace in devman_upiu_cmd
From
Date
On Wed, 2021-06-02 at 10:29 +0800, Can Guo wrote:
> > spin_lock_irqsave(hba->host->host_lock, flags);
> > @@ -6732,6 +6733,8 @@ static int
> > ufshcd_issue_devman_upiu_cmd(struct
> > ufs_hba *hba,
> > err = -EINVAL;
> > }
> > }
> > + ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR :
> > UFS_QUERY_COMP,
> > + (struct utp_upiu_req *)lrbp-
> > >ucd_rsp_ptr);
> > out:
> > blk_put_request(req);
>
>
> What about ufshcd_exec_dev_cmd()?
>


Can,
thanks for your veiew.
yes, ufshcd_exec_dev_cmd() is only to send
UPIU command frame, and doesn't include CDB. It already uses
ufshcd_add_query_upiu_trace() to trace UPIU frame.

Kind regards,
Bean

> Thanks,
>
> Can Guo.

\
 
 \ /
  Last update: 2021-06-02 23:07    [W:0.067 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site