lkml.org 
[lkml]   [2021]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations
    Hi Joakim,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on net-next/master]

    url: https://github.com/0day-ci/linux/commits/Joakim-Zhang/net-fec-fix-TX-bandwidth-fluctuations/20210616-221117
    base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c7654495916e109f76a67fd3ae68f8fa70ab4faa
    config: parisc-randconfig-s031-20210618 (attached as .config)
    compiler: hppa-linux-gcc (GCC) 9.3.0
    reproduce:
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # apt-get install sparse
    # sparse version: v0.6.3-341-g8af24329-dirty
    # https://github.com/0day-ci/linux/commit/a0ef15273c2798319e07a8277161e99b4a22b41e
    git remote add linux-review https://github.com/0day-ci/linux
    git fetch --no-tags linux-review Joakim-Zhang/net-fec-fix-TX-bandwidth-fluctuations/20210616-221117
    git checkout a0ef15273c2798319e07a8277161e99b4a22b41e
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=parisc

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>


    sparse warnings: (new ones prefixed by >>)
    >> drivers/net/ethernet/freescale/fec_main.c:3250:30: sparse: sparse: cast to restricted __be16
    >> drivers/net/ethernet/freescale/fec_main.c:3250:16: sparse: sparse: restricted __be16 degrades to integer

    vim +3250 drivers/net/ethernet/freescale/fec_main.c

    3244
    3245 static u16 fec_enet_get_raw_vlan_tci(struct sk_buff *skb)
    3246 {
    3247 struct vlan_ethhdr *vhdr;
    3248 unsigned short vlan_TCI = 0;
    3249
    > 3250 if (skb->protocol == ntohs(ETH_P_ALL)) {
    3251 vhdr = (struct vlan_ethhdr *)(skb->data);
    3252 vlan_TCI = ntohs(vhdr->h_vlan_TCI);
    3253 }
    3254
    3255 return vlan_TCI;
    3256 }
    3257

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2021-06-18 17:13    [W:3.672 / U:0.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site