lkml.org 
[lkml]   [2021]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH Part1 RFC v3 06/22] x86/sev: check SEV-SNP features support
    On Thu, Jun 17, 2021 at 01:46:08PM -0500, Brijesh Singh wrote:
    > Based on your feedback on AP creation patch to not use the accessors, I am inclined to
    > remove this helper and have the caller directly check the feature bit, is that okay ?
    >
    > something like:
    >
    > if (sev_snp_enabled() && !(hv_features & GHCB_HV_FT_SNP))
    > sev_es_terminate(GHCB_SNP_UNSUPPORTED);
    >
    > Let me know if you think I should still keep the accessors.

    Yeah, looks about right. Let's keep hv_features in a sev-specific
    header so that there are no name clashes. Or maybe we should call it
    sev_hv_features since it is going to be read-only anyway.

    Thx.

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2021-06-18 07:47    [W:4.288 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site