lkml.org 
[lkml]   [2021]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 03/11] x86/cpufeatures: Add TDX Guest CPU feature
    On Fri, Jun 18, 2021 at 03:57:47PM -0700, Kuppuswamy Sathyanarayanan wrote:
    > Add CPU feature detection for Trusted Domain Extensions support. TDX
    > feature adds capabilities to keep guest register state and memory
    > isolated from hypervisor.
    >
    > For TDX guest platforms, executing CPUID(eax=0x21, ecx=0) will return
    > following values in EAX, EBX, ECX and EDX.
    >
    > EAX: Maximum sub-leaf number: 0
    > EBX/EDX/ECX: Vendor string:
    >
    > EBX = "Inte"
    > EDX = "lTDX"
    > ECX = " "
    >
    > So when above condition is true, set X86_FEATURE_TDX_GUEST feature cap
    > bit.
    >
    > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
    > Reviewed-by: Andi Kleen <ak@linux.intel.com>
    > Reviewed-by: Tony Luck <tony.luck@intel.com>
    > ---
    >
    > Changes since v2:
    > * Fixed debug prints as per Borislav suggestion.
    >
    > Changes since v1:
    > * Fixed commit log issues reported by Borislav.
    > * Moved header file include to the start of tdx.h.
    > * Added pr_fmt for TDX.
    > * Simplified cpuid_has_tdx_guest() implementation as per
    > Borislav comments.

    From Documentation/process/submitting-patches.rst:

    "Both Tested-by and Reviewed-by tags, once received on mailing list from tester
    or reviewer, should be added by author to the applicable patches when sending
    next versions. However if the patch has changed substantially in following
    version, these tags might not be applicable anymore and thus should be removed.
    Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
    in the patch changelog (after the '---' separator)."

    IOW, for the next revisions of your patchsets, you should drop
    Reviewed-by: tags on patches when they've changed more than trivially
    because otherwise those tags have no meaning at all.

    Also, please take the time to peruse the above document on the kernel
    process while waiting.

    Thx.

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2021-06-19 01:40    [W:38.231 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site