Messages in this thread | | | Date | Wed, 16 Jun 2021 17:05:10 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/1] powerpc/papr_scm: Properly handle UUID types and API |
| |
On Wed, Jun 16, 2021 at 07:17:03PM +0530, Aneesh Kumar K.V wrote: > On 6/16/21 7:13 PM, Andy Shevchenko wrote: > > Parse to and export from UUID own type, before dereferencing. > > This also fixes wrong comment (Little Endian UUID is something else) > > and should eliminate the direct strict types assignments. > > > > Fixes: 43001c52b603 ("powerpc/papr_scm: Use ibm,unit-guid as the iset cookie") > > Fixes: 259a948c4ba1 ("powerpc/pseries/scm: Use a specific endian format for storing uuid from the device tree") > > Do we need the Fixes: there? It didn't change any functionality right? The > format with which we stored cookie1 remains the same with older and newer > code. The newer one is better?
Depends if you are okay with Sparse warnings.
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Thanks for review!
-- With Best Regards, Andy Shevchenko
| |