Messages in this thread | | | From | Aurélien Aptel <> | Subject | Re: [PATCH] cifs: retry lookup and readdir when EAGAIN is returned. | Date | Wed, 16 Jun 2021 12:07:50 +0200 |
| |
Thanks for the patch and reproducer Thiago.
ronnie sahlberg <ronniesahlberg@gmail.com> writes: > Looks good to me.
I guess it looks ok as a quick fix for the issue at hand but: - should we check for more error codes (use is_retryable_error()?) - all syscalls will need something similar, the session can be closed at any point * either we add a loop everywhere * or we change cifs_send_receive to retry (most?) calls * might be worth looking at what nfs does here - Should this be done for both soft (default) and hard mounts? I guess for hard we would retry indefinitely
Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
| |