Messages in this thread | | | Date | Wed, 16 Jun 2021 09:21:40 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition |
| |
On Wed 2021-06-16 08:56:01, Petr Mladek wrote: > On Tue 2021-06-15 08:50:45, Rasmus Villemoes wrote: > > On 15/06/2021 01.56, Punit Agrawal wrote: > > > Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while > > > improving readability by removing vprintk indirection, inadvertently > > > placed the EXPORT_SYMBOL() for the newly renamed function at the end > > > of the file. > > > > > > For reader sanity, and as is convention move the EXPORT_SYMBOL() > > > declaration just after the end of the function. > > > > > > Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") > > > Signed-off-by: Punit Agrawal <punitagrawal@gmail.com> > > > -- > > > Hi, > > > > > > The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while > > > attempting to rebase the RT patches onto newer kernels.
Ah, this is the explanation. I am sorry for the noise.
> > > Generally I avoid sending trivial changes on their own but this one is > > > a little hard to overlook. Also it felt like an obvious oversight in > > > the original patch. > > > > Petr, as this is causing trouble for the -rt patchset, please consider > > if this could make it to Linus before v5.13 release.
Punit, John, would you mind when I queue this change for-5.14? It seems that, you, RT-guys already handled this, so it will not help much if I sent it now. It does not look appropriate to send just a single cosmetic fix few days before rc7.
Best Regards, Petr
| |