Messages in this thread | | | Date | Wed, 16 Jun 2021 15:15:37 +0800 | From | kernel test robot <> | Subject | Re: [PATCH net-next 10/11] net: marvell: prestera: add storm control (rate limiter) implementation |
| |
Hi Oleksandr,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kselftest/next] [also build test WARNING on net/master linus/master v5.13-rc6] [cannot apply to net-next/master sparc-next/master next-20210615] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oleksandr-Mazur/Marvell-Prestera-driver-implementation-of-devlink-functionality/20210616-112917 base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d1e2db61850ee143f7aa180d34efb413f0956abd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Oleksandr-Mazur/Marvell-Prestera-driver-implementation-of-devlink-functionality/20210616-112917 git checkout d1e2db61850ee143f7aa180d34efb413f0956abd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/marvell/prestera/prestera_devlink.c: In function 'prestera_devlink_port_param_set': >> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:693:26: warning: variable 'sw' set but not used [-Wunused-but-set-variable] 693 | struct prestera_switch *sw; | ^~ drivers/net/ethernet/marvell/prestera/prestera_devlink.c: In function 'prestera_devlink_port_param_get': drivers/net/ethernet/marvell/prestera/prestera_devlink.c:736:26: warning: variable 'sw' set but not used [-Wunused-but-set-variable] 736 | struct prestera_switch *sw; | ^~
vim +/sw +693 drivers/net/ethernet/marvell/prestera/prestera_devlink.c
686 687 static int prestera_devlink_port_param_set(struct devlink_port *dl_port, u32 id, 688 struct devlink_param_gset_ctx *ctx) 689 { 690 struct prestera_strom_control_cfg *cfg; 691 u32 kbyte_per_sec_rate = ctx->val.vu32; 692 struct prestera_port *port; > 693 struct prestera_switch *sw; 694 u32 *param_to_set; 695 u32 storm_type; 696 int ret; 697 698 port = container_of(dl_port, struct prestera_port, dl_port); 699 sw = devlink_priv(dl_port->devlink); 700 cfg = &port->storm_control; 701 702 switch (id) { 703 case PRESTERA_DEVLINK_PORT_PARAM_ID_BC_RATE: 704 param_to_set = &cfg->bc_kbyte_per_sec_rate; 705 storm_type = PRESTERA_PORT_STORM_CTL_TYPE_BC; 706 break; 707 case PRESTERA_DEVLINK_PORT_PARAM_ID_UC_UNK_RATE: 708 param_to_set = &cfg->unk_uc_kbyte_per_sec_rate; 709 storm_type = PRESTERA_PORT_STORM_CTL_TYPE_UC_UNK; 710 break; 711 case PRESTERA_DEVLINK_PORT_PARAM_ID_MC_RATE: 712 param_to_set = &cfg->unreg_mc_kbyte_per_sec_rate; 713 storm_type = PRESTERA_PORT_STORM_CTL_TYPE_MC; 714 break; 715 default: 716 return -EINVAL; 717 } 718 719 if (kbyte_per_sec_rate != *param_to_set) { 720 ret = prestera_hw_port_storm_control_cfg_set(port, storm_type, 721 kbyte_per_sec_rate); 722 if (ret) 723 return ret; 724 725 *param_to_set = kbyte_per_sec_rate; 726 } 727 728 return 0; 729 } 730
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |