Messages in this thread | | | Date | Thu, 17 Jun 2021 08:33:38 +0930 | From | "Andrew Jeffery" <> | Subject | Re: [PATCH][next] ipmi: kcs bmc aspeed: Fix less than zero comparison of a unsigned int |
| |
On Thu, 17 Jun 2021, at 01:59, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The comparisons of the unsigned int hw_type to less than zero always > false because it is unsigned. Fix this by using an int for the > assignment and less than zero check. >
> Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 9d2df9a0ad80 ("ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks for catching that.
Andrew
| |