Messages in this thread | | | Date | Wed, 16 Jun 2021 08:41:05 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/1] mcb: Use DEFINE_RES_MEM() to simplify code |
| |
On Wed, Jun 16, 2021 at 09:55:09AM +0800, Zhen Lei wrote: > Use DEFINE_RES_MEM() to save a couple of lines of code, which makes the > code a bit shorter and easier to read. The start address does not need to > appear twice. > > By the way, the value of '.end' should be "start + size - 1". So the > previous writing should have omitted subtracted 1.
Does that mean the current code is wrong and this is a bugfix? If so, what commit id does this fix?
thanks,
greg k-h
| |