| Subject | Re: [dm-devel] [PATCH 06/18] bvec: add a bvec_kmap_local helper | From | Bart Van Assche <> | Date | Wed, 16 Jun 2021 09:52:18 -0700 |
| |
On 6/15/21 6:24 AM, Christoph Hellwig wrote: > +/** > + * bvec_kmap_local - map a bvec into the kernel virtual address space > + * @bvec: bvec to map > + * > + * Must be called on single-page bvecs only. Call kunmap_local on the returned > + * address to unmap. > + */ > +static inline void *bvec_kmap_local(struct bio_vec *bvec) > +{ > + return kmap_local_page(bvec->bv_page) + bvec->bv_offset; > +}
Hi Christoph,
Would it be appropriate to add WARN_ON_ONCE(bvec->bv_offset >= PAGE_SIZE) in this function?
Thanks,
Bart.
|