lkml.org 
[lkml]   [2021]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 1/5] pstore/blk: Improve failure reporting
Date
There was no feedback on bad registration attempts. Add details on the
failure cause.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/blk.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
index 4bb8a344957a..eca83820fb5d 100644
--- a/fs/pstore/blk.c
+++ b/fs/pstore/blk.c
@@ -114,8 +114,22 @@ static int __register_pstore_device(struct pstore_device_info *dev)

lockdep_assert_held(&pstore_blk_lock);

- if (!dev || !dev->total_size || !dev->read || !dev->write)
+ if (!dev) {
+ pr_err("NULL device info\n");
return -EINVAL;
+ }
+ if (!dev->total_size) {
+ pr_err("zero sized device\n");
+ return -EINVAL;
+ }
+ if (!dev->read) {
+ pr_err("no read handler for device\n");
+ return -EINVAL;
+ }
+ if (!dev->write) {
+ pr_err("no write handler for device\n");
+ return -EINVAL;
+ }

/* someone already registered before */
if (pstore_zone_info)
--
2.25.1
\
 
 \ /
  Last update: 2021-06-16 18:41    [W:0.633 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site