lkml.org 
[lkml]   [2021]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue
>  static int cp_table[EVENTS][STATES] = {
> /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED
> - 0 1 2 3 4 5 6 */
> + * 0 1 2 3 4 5 6
> + */
> {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */
> { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */
> { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */

This probably reduces the readability of the code. So i would not make
this change.

Please remember these are only guidelines. Please don't blindly make
changes, or change it because some bot says so. Check that it actually
makes sense and the code is better afterwards.

Andrew

\
 
 \ /
  Last update: 2021-06-16 18:21    [W:0.461 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site