lkml.org 
[lkml]   [2021]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 17/48] hwmon/pmbus: (q54sj108a2) The PMBUS_MFR_ID is actually 6 chars instead of 5
    Date
    From: Chu Lin <linchuyuan@google.com>

    [ Upstream commit f0fb26c456a30d6009faa2c9d44aa22f5bf88c90 ]

    The PMBUS_MFR_ID block is actually 6 chars for q54sj108a2.
    /sys/bus/i2c/drivers/q54sj108a2_test# iotools smbus_read8 $BUS $ADDR 0x99
    0x06

    Tested: Devices are able to bind to the q54sj108a2 driver successfully.

    Signed-off-by: Chu Lin <linchuyuan@google.com>
    Link: https://lore.kernel.org/r/20210517222606.3457594-1-linchuyuan@google.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/pmbus/q54sj108a2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hwmon/pmbus/q54sj108a2.c b/drivers/hwmon/pmbus/q54sj108a2.c
    index aec512766c31..0976268b2670 100644
    --- a/drivers/hwmon/pmbus/q54sj108a2.c
    +++ b/drivers/hwmon/pmbus/q54sj108a2.c
    @@ -299,7 +299,7 @@ static int q54sj108a2_probe(struct i2c_client *client)
    dev_err(&client->dev, "Failed to read Manufacturer ID\n");
    return ret;
    }
    - if (ret != 5 || strncmp(buf, "DELTA", 5)) {
    + if (ret != 6 || strncmp(buf, "DELTA", 5)) {
    buf[ret] = '\0';
    dev_err(dev, "Unsupported Manufacturer ID '%s'\n", buf);
    return -ENODEV;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-16 17:40    [W:3.715 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site