lkml.org 
[lkml]   [2021]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH V3 08/11] swiotlb: Add bounce buffer remap address setting function
From
Date
On 6/14/2021 11:32 PM, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 02:49:51PM +0100, Robin Murphy wrote:
>> FWIW, I think a better generalisation for this would be allowing
>> set_memory_decrypted() to return an address rather than implicitly
>> operating in-place, and hide all the various hypervisor hooks behind that.
>
> Yes, something like that would be a good idea. As-is
> set_memory_decrypted is a pretty horribly API anyway due to passing
> the address as void, and taking a size parameter while it works in units
> of pages. So I'd very much welcome a major overhaul of this API.
>

Hi Christoph and Robin:
Thanks for your suggestion. I will try this idea in the next version.
Besides make the address translation into set_memory_
decrypted() and return address, do you want to make other changes to the
API in order to make it more reasonable(e.g size parameter)?

Thanks

\
 
 \ /
  Last update: 2021-06-15 17:25    [W:0.097 / U:1.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site